Re: Skipping logical replication transactions on subscriber side

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Skipping logical replication transactions on subscriber side
Date: 2021-11-02 10:07:18
Message-ID: CAA4eK1+UTNe2=7MU8nBi4u_kYgwjJAsYdFkMZ=zKESgxV9RSRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 2, 2021 at 2:17 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Nov 2, 2021 at 2:35 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > > >
> > > > I have another question in this regard. Currently, the reset function
> > > > seems to be resetting only the first stat entry for a subscription.
> > > > But can't we have multiple stat entries for a subscription considering
> > > > the view's cumulative nature?
> > >
> > > I might be missing your points but I think that with the current
> > > patch, the view has multiple entries for a subscription. That is,
> > > there is one apply worker stats and multiple table sync worker stats
> > > per subscription.
> > >
> >
> > Can't we have multiple entries for one apply worker?
>
> Umm, I think we have one stats entry per one logical replication
> worker (apply worker or table sync worker). Am I missing something?
>

No, you are right. I got confused.

> >
> > > And pg_stat_reset_subscription() function can reset
> > > any stats by specifying subscription OID and relation OID.
> > >
> >
> > Say, if the user has supplied just subscription OID then isn't it
> > better to reset all the error entries for that subscription?
>
> Agreed. So pg_stat_reset_subscription_worker(oid) removes all errors
> for the subscription whereas pg_stat_reset_subscription_worker(oid,
> null) reset only the apply worker error for the subscription?
>

Yes.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-11-02 10:37:48 Re: Added schema level support for publication.
Previous Message Daniel Gustafsson 2021-11-02 10:06:46 Re: remove internal support in pgcrypto?