| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | MauMau <maumau307(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [bug fix] pg_ctl always uses the same event source |
| Date: | 2014-07-18 03:33:35 |
| Message-ID: | CAA4eK1+U4EoFA85_xnsrndhzK+Jy3kQoRF3uxTwzakqK5OtbcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 17, 2014 at 4:51 PM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:
>
> Did anyone actually test this patch? :)
>
> I admit I did not build it on Windows specifically because I assumed
> that was done as part of the development and review. And the changes
> to pg_event.c can never have built, since the file does not include
> the required header.
I have tested it on Windows and infact on Linux as well to see if there
is any side impact before marking it as Ready For Committer.
It seems to me that the required header is removed in last version
(pg_ctl_eventsrc_v11) where MessageBox() related changes have been
removed from patch as per recent discussion. Sorry for not being able
to check last version posted.
> I have reverted that part of the patch for now, hopefully that'll
> unbreak the buildfarm.
Do you want me to write a patch to use DEFAULT_EVENT_SOURCE in
pgevent?
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip kumar | 2014-07-18 04:52:18 | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] |
| Previous Message | Craig Ringer | 2014-07-18 02:21:17 | Re: [TODO] Process pg_hba.conf keywords as case-insensitive |