From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | 自己 <zoulx1982(at)163(dot)com> |
Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Re: BUG #15039: some question about hash index code |
Date: | 2018-01-31 12:44:51 |
Message-ID: | CAA4eK1+TOrM09OYhAff2O4oYtWxOz4WsTTsf2UEstoW6owaZxw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Wed, Jan 31, 2018 at 5:57 PM, 自己 <zoulx1982(at)163(dot)com> wrote:
> thank you for your quick reply.
> and i have another question, for the following code, whether exist such
> scene : page_found is false and
> newmapbuf is invalid, if so, may be the statement MarkBufferDirty(metabuf);
> should be placed outside the if statement ?
>
On a quick look, your observation seems to be right and I think in
this function we might call markbufferdirty twice for meta page which
doesn't seem to be required. In any case, tomorrow I will look at
this code again and can send a patch to fix it unless you want to send
a patch to fix it.
Thanks for reporting the problem.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | PG Bug reporting form | 2018-01-31 16:23:38 | BUG #15040: "could not open relation" error |
Previous Message | 自己 | 2018-01-31 12:27:26 | Re:Re: BUG #15039: some question about hash index code |
From | Date | Subject | |
---|---|---|---|
Next Message | sanyam jain | 2018-01-31 12:51:57 | Re: [HACKERS] Why forcing Hot_standby_feedback to be enabled when creating a logical decoding slot on standby |
Previous Message | 自己 | 2018-01-31 12:27:26 | Re:Re: BUG #15039: some question about hash index code |