Re: pgsql: Allow tailoring of ICU locales with custom rules

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow tailoring of ICU locales with custom rules
Date: 2023-09-04 13:05:14
Message-ID: CAA4eK1+Rc-gX7RobePq4uteZFT2crxy7JG_SNyEvT7zWa6tPeg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Aug 22, 2023 at 10:55 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Mon, 2023-08-14 at 10:34 +0200, Peter Eisentraut wrote:
> > I have investigated this. My assessment is that how PostgreSQL
> > interfaces with ICU is correct. Whether what ICU does is correct
> > might
> > be debatable. I have filed a bug with ICU about this:
> > https://unicode-org.atlassian.net/browse/ICU-22456 , but there is no
> > response yet.
>
> Is everything other than the language and region simply discarded when
> a rules string is present, or are some attributes preserved, or is
> there some other nuance?
>
> > You can work around this by including the desired attributes in the
> > rules string, for example
> >
> > create collation c3 (provider=icu,
> > locale='und-u-ka-shifted-ks-level1',
> > rules='[alternate shifted][strength 1]',
> > deterministic=false);
> >
> > So I don't think there is anything we need to do here for PostgreSQL
> > 16.
>
> Is there some way we can warn a user that some attributes will be
> discarded, or improve the documentation? Letting the user figure this
> out for themselves doesn't seem right.
>
> Are you sure we want to allow rules for the database default collation
> in 16, or should we start with just allowing them in CREATE COLLATION
> and then expand to the database default collation later? I'm still a
> bit concerned about users getting too fancy with daticurules, and
> ending up not being able to connect to their database anymore.
>

There is still an Open Item corresponding to this. Does anyone else
want to weigh in?

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-09-04 13:56:04 Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
Previous Message Peter Eisentraut 2023-09-04 12:58:45 Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2023-09-04 13:22:40 Re: Commitfest 2023-09 starts soon
Previous Message Ashutosh Bapat 2023-09-04 12:57:33 Re: Speaker Bureau