Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

On Wed, Nov 13, 2013 at 4:05 PM, Haribabu kommi
<haribabu(dot)kommi(at)huawei(dot)com> wrote:
> On 01 October 2013 00:56 Amit Kapila wrote:
>> On Mon, Sep 30, 2013 at 9:07 PM, Peter Eisentraut <peter_e(at)gmx(dot)net>
>> wrote:
>> > On 9/28/13 3:05 AM, Amit Kapila wrote:
>> >> Now as we have an agreement, I had updated patch for below left
>> issues:
>> >
>> > Regression tests are failing.
>>
>> Thanks for informing. I am sorry for not running regression before
>> sending patch.
>>
>> Reason for failure was that source for GUC in new function
>> validate_conf_option() was hardcoded to PGC_S_FILE which was okay for
>> Alter System, but
>> not for SET path. I had added new parameter source in this function
>> and get the value of source when this is called from SET path.
>
> Some of the initial observation of the patch are,
> 1. Patch is not applying against git head, needs a rebase.
> 2. Patch doesn't contain the tests.
It was intentional and as per feedback for this patch. As for
testing this feature, we need to put sleep after operation, so it was
suggested to remove tests.

> I started reviewing the patch, will share the details once I finish.
Thanks.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com