| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Subscription tests fail under CLOBBER_CACHE_ALWAYS |
| Date: | 2021-05-21 05:15:58 |
| Message-ID: | CAA4eK1+QVHSzJFR+BH=5GpmMph+Kn+w6mpWHPnUP0xNc2jWA_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 21, 2021 at 6:29 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, May 20, 2021 at 02:57:40PM -0400, Tom Lane wrote:
> > Here's a version that does it like that. I'm not entirely convinced
> > whether this is better or not.
>
> Hmm. I think that this is better. This makes the code easier to
> follow, and the extra information is useful for debugging.
>
> The change looks good to me.
>
Yeah, the change looks good to me as well but I think we should
consider Amit L's point that maintaining this extra activeRelInfo
might be prone to bugs if the partitioning logic needs to be extended
at other places in the worker.c. As the code stands today, it doesn't
seem problematic so we can go with the second patch if both Tom and
you feel that is a better option.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-05-21 05:40:15 | Re: parallel vacuum - few questions on docs, comments and code |
| Previous Message | Greg Nancarrow | 2021-05-21 04:46:11 | Re: Re[3]: On login trigger: take three |