| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Resetting spilled txn statistics in pg_stat_replication |
| Date: | 2020-09-09 09:50:32 |
| Message-ID: | CAA4eK1+NTpkTbv+P21Bft+=Mfy-R2rJtz9q7Hm0Y-d-6e692BA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 8, 2020 at 7:02 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Comments on the latest patch:
> =============================
>
Apart from the comments I gave yesterday, another thing I was
wondering is how to write some tests for this patch. The two ideas I
could think of are as follows:
1. One idea was to keep these stats for each WALSender as it was in
the commit that we reverted as b074813d48. If we had that then we can
query the stats for tests added in commit 58b5ae9d62. I am not sure
whether we want to display it in view pg_stat_replication but it would
be a really good way to test the streamed and serialized transactions
in a predictable manner.
2. Then the second way is to try doing something similar to what we do
in src/test/regress/sql/stats.sql
I think we should do both if possible.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2020-09-09 10:02:54 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Magnus Hagander | 2020-09-09 09:46:56 | Re: Inconsistency in determining the timestamp of the db statfile. |