Re: [PATCH v1] eliminate duplicate code in table.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 11:09:35
Message-ID: CAA4eK1+N-bZivTO=2LZH93jxQAwSi+0xvW-Gg1yN_WS2PujwMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 21, 2022 at 1:56 PM Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
>
> There are some duplicate code in table.c, add a static inline function
> to eliminate the duplicates.
>

Can we name function as validate_object_type, or check_object_type?

Otherwise, the patch looks fine to me. Let's see if others have
something to say.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-07-21 11:11:26 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message Alvaro Herrera 2022-07-21 11:01:06 Re: standby recovery fails (tablespace related) (tentative patch and discussion)