| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PG Docs - CREATE SUBSCRIPTION option list order |
| Date: | 2021-09-09 04:20:17 |
| Message-ID: | CAA4eK1+Lxg7HzFu0cTMnyBheufpowv0aPzY7RZ8+FF0E8cw1Fg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 8, 2021 at 12:24 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> v2 --> v3
>
> The subscription_parameter names are now split into 2 groups using
> Amit's suggestion [1] on how to categorise them.
>
> I also made some grammar improvements to their descriptions.
>
I have made minor edits to your first patch and it looks good to me. I
am not sure what exactly Tom has in mind related to grammatical
improvements, so it is better if he can look into that part of your
proposal (basically second patch
v4-0002-PG-Docs-Create-Subscription-options-rewording).
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Doc-Change-optional-parameters-grouping-in-Create.patch | application/octet-stream | 8.7 KB |
| v4-0002-PG-Docs-Create-Subscription-options-rewording.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-09 04:23:10 | Re: Estimating HugePages Requirements? |
| Previous Message | Michael Paquier | 2021-09-09 04:19:14 | Re: Estimating HugePages Requirements? |