| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "Shinoda, Noriyoshi (SXD Japan FSI)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-24 04:15:29 |
| Message-ID: | CAA4eK1+LihJd5FmmXXxcUD_9bgCsXZqF+PcxDU_p8OK_CUzw_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 24, 2025 at 8:39 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > On Fri, Jan 24, 2025 at 4:41 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >> However, in hindsight, I am not sure that the column should have been
> >> renamed 'pubgencols_type' in the first place because I cannot find any
> >> other catalogs with an underscore in their column names.
>
> > See pg_rewrite.ev_type for a similar case.
>
> I think the problem is not so much the underscore as the
> inconsistency. You've got "pub", "gen", and "cols" run together,
> but then you feel a need to separate "type"?
>
It was easy to read and to avoid getting a single word too long.
However, I do understand your concern. so will change it to
pubgencolstype unless you or someone prefers pubgencols?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-01-24 04:21:46 | Re: Pgoutput not capturing the generated columns |
| Previous Message | Tom Lane | 2025-01-24 03:09:07 | Re: Pgoutput not capturing the generated columns |