| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo about subxip in comments |
| Date: | 2022-11-11 07:23:15 |
| Message-ID: | CAA4eK1+JP4AW-kWq-m3nrgVCOAg_XiqBmPn=iL7VEUZ_3OaW=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 11, 2022 at 12:16 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Fri, Nov 11, 2022 at 11:26 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>> Recently, when I read the XidInMVCCSnapshot(), and find there are some
>> typos in the comments.
>
>
> Hmm, it seems to me 'the subxact array' is just another saying to refer
> to snapshot->subxip. I'm not sure about this being typo. But I have no
> objection to this change, as it is more consistent with the 'xip array'
> saying followed.
>
Agreed, it is more about being consistent with xip array.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-11-11 08:11:25 | Re: proposal: possibility to read dumped table's name from file |
| Previous Message | Amit Kapila | 2022-11-11 07:21:45 | Re: Perform streaming logical transactions by background workers and parallel apply |