| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: parallel vacuum comments |
| Date: | 2021-12-21 05:04:06 |
| Message-ID: | CAA4eK1+FoAvGy_td8bcSjoBC3e+SbArjespGyq=PVZ7oFworag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 21, 2021 at 10:05 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Dec 21, 2021 at 12:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, Dec 20, 2021 at 6:29 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> > BTW, if we go with that then we should set the correct phase
> > for workers as well?
>
> If we have separate error context for the leader (vacuumlazy.c) and
> workers (vacuumparallel.c), workers don't necessarily need to have the
> phases such as VACUUM_ERRCB_PHASE_VACUUM_INDEX and
> VACUUM_ERRCB_PHASE_INDEX_CLEANUP. They can use PVIndVacStatus in the
> error callback function as the patch does.
>
Okay. One minor point, let's change comments atop vacuum.c considering
the movement of new functions.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-12-21 05:23:31 | Re: row filtering for logical replication |
| Previous Message | Greg Stark | 2021-12-21 04:58:07 | Re: Getting rid of regression test input/ and output/ files |