| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix warnings and typo in dshash |
| Date: | 2017-09-03 06:57:12 |
| Message-ID: | CAA4eK1+5vfVMYtjK_NX8O3-42yM3o80qdqWnQzGquPrbq6mb+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I am seeing below warnings (on Win7) in dshash.c
1> dshash.c
1>src/backend/lib/dshash.c(318): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
1>src/backend/lib/dshash.c(679): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
1>src/backend/lib/dshash.c(713): warning C4334: '<<' : result of
32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
Attached a patch to fix the above warning.
I have noticed a typo in dshash.h for which a separate patch is attached.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_warnings_dshash_v1.patch | application/octet-stream | 1.1 KB |
| fix_typo_dshash_v1.patch | application/octet-stream | 760 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2017-09-03 07:04:32 | Re: JIT & function naming |
| Previous Message | Andres Freund | 2017-09-02 23:59:55 | Re: JIT & function naming |