Re: Added schema level support for publication.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Subject: Re: Added schema level support for publication.
Date: 2021-08-06 10:32:00
Message-ID: CAA4eK1+5FQGL=MaviWrOrUq2WvouLb08xWzRQOkG8cxdmthYgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 6, 2021 at 2:16 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, Aug 5, 2021 at 3:54 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > Few more comments:
> > ===================
> > 1. Do we need the previous column 'puballtables' after adding pubtype
> > or pubkind in pg_publication?
>
> I felt this should be retained as old client will still be using puballtables, like in case of old client executing \dRp+ commands.
>

But do we guarantee that old clients work with newer server versions?
For example, psql docs say: "psql works best with servers of the same
or an older major version. Backslash commands are particularly likely
to fail if the server is of a newer version than psql itself." [1]
(See Notes Section). Similarly, pg_dump docs say: "However, pg_dump
cannot dump from PostgreSQL servers newer than its own major version;
it will refuse to even try, rather than risk making an invalid dump."
[2] (See Notes Section).

It seems Sawada-San has the same question and IIUC docs suggest we
don't need such compatibility, so what makes you think we need it?

[1] - https://www.postgresql.org/docs/devel/app-psql.html
[2] - https://www.postgresql.org/docs/devel/app-pgdump.html

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-08-06 11:09:25 Re: Added schema level support for publication.
Previous Message Itamar Gafni 2021-08-06 10:16:07 [PATCH] OpenSSL: Mark underlying BIO with the appropriate type flags