Re: parallel vacuum options/syntax

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: parallel vacuum options/syntax
Date: 2020-01-08 06:31:38
Message-ID: CAA4eK1+3zMNdHYKnmGTPoCSK=QNDV=zwj=n6O2T+g+4ZV+NX7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 8, 2020 at 11:31 AM Masahiko Sawada
<masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> On Mon, 6 Jan 2020 at 15:27, Masahiko Sawada
> <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
> >
> > I just felt it's not intuitive that specifying parallel degree to 0
> > means to disable parallel vacuum. But since majority of hackers seem
> > to agree with this syntax I'm not going to insist on that any further.
> >
>
> Okay I'm going to go with enabling parallel vacuum by default and
> disabling it by specifying PARALLEL 0.
>

Sounds fine to me. However, I have already started updating the patch
for that. I shall post the new version today or tomorrow. Is that
fine with you?

> For combination of VACUUM command options, although parallel vacuum is
> enabled by default and VACUUM FULL doesn't support it yet, 'VACUUM
> (FULL)' would work. On the other hand 'VACUUM (FULL, PARALLEL)' and
> 'VACUUM(FULL, PARALLEL 1)' would not work with error. And I think it
> is better if 'VACUUM (FULL, PARALLEL 0)' also work but I'd like to
> hear opinions.
>

I agree with all these points.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2020-01-08 06:54:05 Re: jsonb_set() strictness considered harmful to data
Previous Message Masahiko Sawada 2020-01-08 06:01:17 Re: parallel vacuum options/syntax