| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2021-08-12 11:18:24 |
| Message-ID: | CAA4eK1+3jPCjgtBWi+oUkRR=UgaMJiS_g8ctjk49R+tvQaP1OA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 12, 2021 at 1:21 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, Aug 12, 2021 at 3:54 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I've attached the updated patches. FYI I've included the patch
> > (v8-0005) that fixes the assertion failure during shared fileset
> > cleanup to make cfbot tests happy.
> >
>
> A minor comment on the 0001 patch: In the message I think that using
> "ID" would look better than lowercase "id" and AFAICS it's more
> consistent with existing messages.
>
> + appendStringInfo(&buf, _(" in transaction id %u with commit timestamp %s"),
>
You have a point but I think in this case it might look a bit odd as
we have another field 'commit timestamp' after that which is
lowercase.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-12 11:28:23 | Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash |
| Previous Message | Amit Kapila | 2021-08-12 11:00:12 | Re: [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash |