From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Andreas Joseph Krogh <andreas(at)visena(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ERROR: ORDER/GROUP BY expression not found in targetlist |
Date: | 2016-06-17 06:14:39 |
Message-ID: | CAA4eK1+27huT5p6OMvkK31Myhhuga4DbpyW+viEf_NN-EA9DVw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 17, 2016 at 11:39 AM, Andreas Joseph Krogh <andreas(at)visena(dot)com>
wrote:
> På torsdag 16. juni 2016 kl. 20:19:44, skrev Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>
> Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com> writes:
> > On Mon, Jun 13, 2016 at 10:36 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> min_parallel_relation_size, or min_parallelizable_relation_size, or
> >> something like that?
>
> > You are right that such a variable will make it simpler to write tests
> for
> > parallel query. I have implemented such a guc and choose to keep the
> name
> > as min_parallel_relation_size.
>
> Pushed with minor adjustments. My first experiments with this say that
> we should have done this long ago:
> https://www.postgresql.org/message-id/22782.1466100870@sss.pgh.pa.us
>
> > One thing to note is that in function
> > create_plain_partial_paths(), curently it is using PG_INT32_MAX/3 for
> > parallel_threshold to check for overflow, I have changed it to INT_MAX/3
> so
> > as to be consistent with guc.c. I am not sure if it is advisable to use
> > PG_INT32_MAX in guc.c as other similar parameters use INT_MAX.
>
> I agree that using INT_MAX is more consistent with the code elsewhere in
> guc.c, and more correct given that we declare the variable in question
> as int not int32. But you need to include <limits.h> to use INT_MAX ...
>
> regards, tom lane
>
>
> As of 4c56f3269a84a81461cc53941e0eee02fc920ab6 I'm still getting it in one
> of my queries:
> ORDER/GROUP BY expression not found in targetlist
>
I am working on preparing a patch to fix this issue.
> Am I missing something?
>
No, the fix is still not committed.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Joseph Krogh | 2016-06-17 06:19:05 | Re: ERROR: ORDER/GROUP BY expression not found in targetlist |
Previous Message | Craig Ringer | 2016-06-17 06:09:40 | Re: pg_isready features |