Re: [HACKERS] logical decoding of two-phase transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-08-02 09:24:16
Message-ID: CAA4eK1+-Gat6y5PRdu4y5xhKZrv=MeOFKDJkdQMoSoJNKbLVFg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Aug 1, 2021 at 3:51 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Sun, Aug 1, 2021 at 3:05 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Sat, Jul 31, 2021 at 11:12 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> > >
> > > On Sat, Jul 31, 2021 at 2:39 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > > > Here, the test is expecting 2 prepared transactions corresponding to
> > > > two subscriptions but it waits for just one subscription via
> > > > appname_copy. It should wait for the second subscription using
> > > > $appname as well.
> > > >
> > > > What do you think?
> > >
> > > I agree with this analysis. The test needs to wait for both
> > > subscriptions to catch up.
> > > Attached is a patch that addresses this issue.
> >
> > The changes look good to me.
> >
>
> The patch to the test code posted by Ajin LGTM also.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message tanghy.fnst@fujitsu.com 2021-08-02 10:01:24 [PATCH]Comment improvement in publication.sql
Previous Message Amit Kapila 2021-08-02 09:20:27 Re: logical replication empty transactions