| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Henry Hinze <henry(dot)hinze(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop |
| Date: | 2020-11-26 12:36:40 |
| Message-ID: | CAA4eK1+=ci_6dNd1f-Qr6OpCNda=48ZpZd1x3EbPzq4jaB-bZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Nov 26, 2020 at 12:24 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
>
> - And I also thought it would be neater to simply move the
> process_syncing_tables by one line so you can do the stream file
> resource cleanup explicitly the normal way instead of relying on
> implicit cleanup as the tablesync process exits.
>
Okay, I see your point, so changed it accordingly and fixed the code
comments as suggested by you. Does this address all your
concerns/suggestions?
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-replication-of-in-progress-transactions-in-ta.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleksandr Shulgin | 2020-11-26 12:54:24 | Re: Ошибка_установки_postgresql 11_в_ windows |
| Previous Message | Dave Page | 2020-11-26 11:38:35 | Re: pgadmin--pgagent---the process hang by unknow reasons |