Re: [pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)

From: Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)
Date: 2020-04-17 11:38:11
Message-ID: CAA3zdZqfE+28J=RRS4O+aFLTHftNAPeDFq1YCgkQoSkbN-FFtA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,
Please find an updated patch with updated screenshots and documentation
changes.

On Fri, Apr 17, 2020 at 12:28 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Nagesh
>
> Patch looks good to me. Please update the screenshot and documentation for
> the Preferences and Query Tool.
>
> On Thu, Apr 16, 2020 at 4:43 PM Nagesh Dhope <
> nagesh(dot)dhope(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>> This patch allows user to download CSV as a '.csv' file if
>> delimiter character is set to comma(,) else it will download it as '.txt'
>> file.
>>
>> This patch also contains test cases for some missing scenarios for
>> download CSV API.
>>
>> --
>> Thanks,
>> Nagesh
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks,
Nagesh

Attachment Content-Type Size
RM4573_v2.patch application/octet-stream 6.0 MB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-17 12:07:33 pgAdmin 4 commit: Fixed encoding issue while saving data in encoded cha
Previous Message Amol Vyavahare 2020-04-17 10:18:58 Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.