Re: pgsql: Make VACUUM avoid waiting for a cleanup lock, where possible.

From: Thom Brown <thom(at)linux(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Make VACUUM avoid waiting for a cleanup lock, where possible.
Date: 2011-11-08 07:43:55
Message-ID: CAA-aLv78WFAbcSBrdWkWZcsFJvHxJn8NSsi3K-7nzL_T8QZ=UA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 8 November 2011 02:46, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Make VACUUM avoid waiting for a cleanup lock, where possible.
>
> In a regular VACUUM, it's OK to skip pages for which a cleanup lock
> isn't immediately available; the next VACUUM will deal with them.  If
> we're scanning the entire relation to advance relfrozenxid, we might
> need to wait, but only if there are tuples on the page that actually
> require freezing.  These changes should greatly reduce the incidence
> of of vacuum processes getting "stuck".

Minor comment typo but a typo nonetheless:

It's OK to skip vacuuming a page, as long as its not got data

Should be:

It's OK to skip vacuuming a page, as long as it's not got data

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2011-11-08 07:47:42 pgsql: Adjust range type docs for some last-minute changes I made to th
Previous Message Thom Brown 2011-11-08 07:38:37 Re: pgsql: Remove hstore's text => text operator.