Re: pgsql: Add pg_xlogdump contrib program

On 22 February 2013 19:58, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Add pg_xlogdump contrib program
>
> This program relies on rm_desc backend routines and the xlogreader
> infrastructure to emit human-readable rendering of WAL records.
>
> Author: Andres Freund, with many reworks by Álvaro
> Reviewed (in a much earlier version) by Peter Eisentraut
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/639ed4e84b7493594860f56b78b25fd113e78fd7
>
> Modified Files
> --------------
> contrib/pg_xlogdump/Makefile | 32 ++
> contrib/pg_xlogdump/compat.c | 94 +++++
> contrib/pg_xlogdump/pg_xlogdump.c | 711 +++++++++++++++++++++++++++++++++++++
> contrib/pg_xlogdump/rmgrdesc.c | 36 ++
> contrib/pg_xlogdump/rmgrdesc.h | 21 ++
> doc/src/sgml/contrib.sgml | 1 +
> doc/src/sgml/filelist.sgml | 1 +
> doc/src/sgml/pg_xlogdump.sgml | 205 +++++++++++
> doc/src/sgml/ref/pg_isready.sgml | 2 +-
> src/include/utils/palloc.h | 4 +-
> 10 files changed, 1104 insertions(+), 3 deletions(-)

Hmm... did you try building the docs before committing this? I'm
getting an error.

make -C sgml html
make[1]: Entering directory `/home/thom/Development/postgresql/doc/src/sgml'
openjade -wall -wno-unused-param -wno-empty -wfully-tagged -D . -D .
-c /usr/share/sgml/docbook/stylesheet/dsssl/modular/catalog -d
stylesheet.dsl -t sgml -i output-html -V html-index postgres.sgml
openjade:pg_xlogdump.sgml:6:16:E: character "_" is not allowed in the
value of attribute "ID"
openjade:pg_xlogdump.sgml:18:20:E: character "_" is not allowed in the
value of attribute "ZONE"
openjade:pg_xlogdump.sgml:203:10:E: end tag for element "RFSECT1"
which is not open
openjade:pg_xlogdump.sgml:205:10:E: end tag for "REFSECT1" omitted,
but OMITTAG NO was specified
openjade:pg_xlogdump.sgml:197:1: start tag was here
make[1]: *** [HTML.index] Error 1
make[1]: *** Deleting file `HTML.index'
make[1]: Leaving directory `/home/thom/Development/postgresql/doc/src/sgml'
make: *** [html] Error 2

--
Thom