| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix typos in comments. |
| Date: | 2014-03-17 16:55:39 |
| Message-ID: | CAA-aLv6eoxthHay9S_xr+wtbX8Hpuqtu1qD8rZHjspse2jMM-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 17 March 2014 12:44, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Fujii Masao wrote:
>
>> src/backend/access/heap/rewriteheap.c | 6 +++---
>
> This one wasn't strictly a typo:
>
> @@ -1046,7 +1046,7 @@ logical_rewrite_log_mapping(RewriteState state, TransactionId xid,
>
> /*
> * Perform logical remapping for a tuple that's mapped from old_tid to
> - * new_tuple->t_self by rewrite_heap_tuple() iff necessary for the tuple.
> + * new_tuple->t_self by rewrite_heap_tuple() if necessary for the tuple.
> */
>
>
> "iff" was discussed in pg-hackers a fortnight ago or so. In this
> particular case I don't think "iff" rather than "if" added too much to
> the sentence, though, so I think it's fine as it is.
Could you elaborate, for my sake?
--
Thom
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-17 17:00:01 | Re: pgsql: Fix typos in comments. |
| Previous Message | Alvaro Herrera | 2014-03-17 16:41:53 | Re: pgsql: During index build, check and elog (not just Assert) for broken |