| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FDW system columns |
| Date: | 2011-11-14 13:07:54 |
| Message-ID: | CAA-aLv6PWOux8GnC3ZgwiVrvYh64gh+Qs136FDxbXu4Pq8jkpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2011/11/14 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
> (2011/11/14 11:25), Robert Haas wrote:
> > My vote is to nuke 'em all. :-)
>
> +1.
>
> IIRC, main purpose of supporting tableoid for foreign tables was to be
> basis of foreign table inheritance, which was not included in 9.1, and
> we have not supported it yet. Other system columns are essentially
> garbage, but they survived at 9.1 development because (maybe) it seemed
> little odd to have system columns partially at that time.
>
> So, IMHO removing all system columns from foreign tables seems
> reasonable, unless it doesn't break any external tool seriously (Perhaps
> there would be few tools which assume that foreign tables have system
> columns).
>
> If there seems to be a consensus on removing system column from foreign
> tables, I'd like to work on this issue. Attached is a halfway patch,
> and ISTM there is no problem so far.
>
I can say that at least PgAdmin doesn't use these columns.
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-11-14 13:11:16 | Re: Cause of intermittent rangetypes regression test failures |
| Previous Message | Shigeru Hanada | 2011-11-14 12:53:55 | Re: FDW system columns |