| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: File not found error on creating collation |
| Date: | 2011-09-20 16:51:27 |
| Message-ID: | CAA-aLv61Cd7gTbU_iF721sRQ16+6eBr8VVPY-_WppEv57pPWpg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 September 2011 17:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thom Brown <thom(at)linux(dot)com> writes:
>> [ unhelpful reporting of ENOENT from newlocale() ]
>
> BTW, on examining the code I note that we're doing something else that
> promotes the confusion of "bad locale name" with "bad file name": we're
> using errcode_for_file_access() to select the SQLSTATE. If we don't
> believe that ENOENT should be taken at face value then this is pointless
> (none of the other spec-defined error codes for newlocale() are
> particularly sensible as file access errors). I propose just reporting
> ERRCODE_INVALID_PARAMETER_VALUE instead.
*nods*
--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2011-09-20 17:01:01 | Re: unite recovery.conf and postgresql.conf |
| Previous Message | Tom Lane | 2011-09-20 16:45:31 | Re: File not found error on creating collation |