Re: Command Triggers, patch v11

On 9 March 2012 00:28, Thom Brown <thom(at)linux(dot)com> wrote:
> On 8 March 2012 22:24, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
>
> We're getting there. :)

It was late last night and I forgot to get around to testing pg_dump,
which isn't working correctly:

--
-- Name: cmd_trg_after_alter_aggregate; Type: COMMAND TRIGGER; Schema:
-; Owner:
--

CREATE COMMAND TRIGGER cmd_trg_after_alter_aggregate AFTER"ALTER
AGGREGATE" EXECUTE PROCEDURE cmd_trg_info ();

There shouldn't be quotes around the command, and when removing them,
ensure there's a space before the command. All variations of the
ALTER statements in the dump are fine, so are CREATE statements for
ANY COMMAND command triggers.

Also I notice that CREATE/ALTER/DROP COMMAND TRIGGER appears just
before CREATE/ALTER/DROP TRIGGER in the documentation. This breaks
the alphabetical order and I wasn't expecting to find it there when
scanning down the page. Could we move them into an alphabetic
position?

--
Thom