Re: pgsql: Fix issues with pg_ctl

From: Thom Brown <thom(at)linux(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix issues with pg_ctl
Date: 2014-03-05 11:48:02
Message-ID: CAA-aLv4Svd1bXTWzHbi6kwPO0Z4GWnD7Pr7BDH4zTTKnHo5ucg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 5 March 2014 06:33, Stephen Frost <sfrost(at)snowman(dot)net> wrote:

> Fix issues with pg_ctl
>
> The new, small, free_readfile managed to have bug in it which could
> cause it to try and free something it shouldn't, and fix the case
> where it was being called with an invalid pointer leading to a
> segfault.
>
> Noted by Bruce, issues introduced and fixed by me.

Yeah, this has fixed the segfaults, thanks.

Now I get an issue when restarting my cluster, but not when I stop and
start:

thom(at)swift ~/dbtest $ pg_ctl stop -D primary
waiting for server to shut down.... done
server stopped
thom(at)swift ~/dbtest $ pg_ctl start -D primary
server starting
thom(at)swift ~/dbtest $ 2014-03-05 11:46:21.963 GMT - - LOG: redirecting
log output to logging collector process
2014-03-05 11:46:21.963 GMT - - HINT: Future log output will appear in
directory "pg_log".

thom(at)swift ~/dbtest $ pg_ctl restart -D primary
waiting for server to shut down.... done
server stopped
server starting
thom(at)swift ~/dbtest $ sh: 1: ���: not found

--
Thom

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-03-05 12:19:31 pgsql: Fix lastReplayedEndRecPtr calculation when starting from shutdow
Previous Message Stephen Frost 2014-03-05 06:33:19 pgsql: Fix issues with pg_ctl