| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Confusing recovery message when target not hit |
| Date: | 2016-06-13 00:53:48 |
| Message-ID: | CAA-aLv4QyTzsaT6RpLvZp0N4yUVMx3X=UU0LNdv136PRXVDvNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12 June 2016 at 12:51, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sun, Jun 12, 2016 at 7:52 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> > Aren't those already set by recoveryStopsBefore()?
>
> It is possible to exit the main redo loop if a NULL record is found
> after calling ReadRecord, in which case those would not be set, no?
>
I'm apprehensive about initialising those values myself as I don't want to
set them at a point where they may potentially already be set.
And I've noticed that I didn't re-read my own output messages, so I've
corrected them in the attached patch.
Thom
| Attachment | Content-Type | Size |
|---|---|---|
| meaningful_premature_recovery_messages_v3.patch | application/x-patch | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-06-13 01:16:44 | Re: Rename max_parallel_degree? |
| Previous Message | Andres Freund | 2016-06-12 21:51:40 | Re: [PERFORM] 9.4 -> 9.5 regression with queries through pgbouncer on RHEL 6 |