From: | Thom Brown <thom(at)linux(dot)com> |
---|---|
To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
Cc: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>, Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Tables node (pgAdmin4) |
Date: | 2016-05-26 10:34:26 |
Message-ID: | CAA-aLv4JqnFtf1t8GbGp9F8m1ocag=ZmQ_x3Y4FjsuChZbtvsg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On 26 May 2016 at 11:20, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> PFA patch for RM#1231 & RM#1237.
>
> Additionally I have shifted 'Advanced tab' after columns & constraint tab.
>
>
> @Thom,
>
> Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to
> populate "Of type" combo box as given below.
> I was not able to find a way to differentiate between table & composite
> type populating from below given query,
> I'll put in todo list, may be someone from community can help in future.
>
> SELECT t.oid,
> quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
> FROM pg_type t, pg_namespace n
> WHERE t.typtype='c' AND t.typnamespace=n.oid
> AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
> ORDER BY typname;
>
>
This should work:
SELECT c.oid,
quote_ident(n.nspname)||'.'||quote_ident(c.relname) AS typname
FROM pg_namespace n, pg_class c
WHERE c.relkind = 'c' AND c.relnamespace=n.oid
AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;
Although, to avoid confusion, the "typname" alias should probably just be
"relname".
Thom
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-05-26 11:11:20 | Re: [PATCH] Tables node (pgAdmin4) |
Previous Message | Murtuza Zabuawala | 2016-05-26 10:20:09 | Re: [PATCH] Tables node (pgAdmin4) |