Re: pgsql: Documentation for logical decoding.

From: Thom Brown <thom(at)linux(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Documentation for logical decoding.
Date: 2014-03-18 18:12:25
Message-ID: CAA-aLv4C4TKwNG6ARWGsdyuGs1uZEVwR9XOGX3_w6nTko9FQ-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 18 March 2014 17:21, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Documentation for logical decoding.
>
> Craig Ringer, Andres Freund, Christian Kruse, with edits by me.

In doc/src/sgml/logicaldecoding.sgml:

s/demonstartes/demonstrates/

s/ot at least 1/to at least 1/

In this example:

+postgres=# SELECT * FROM
pg_logical_slot_get_changes('regression_slot', NULL, NULL);
+ location | xid | data
+-----------+-----+-----------------------------------------------
+ 0/16E0478 | 689 | BEGIN 689
+ 0/16E0478 | 689 | table public.data: INSERT: id[int4]:1 data[text]:'1'
+ 0/16E0580 | 689 | table public.data: INSERT: id[int4]:2 data[text]:'2'
+ 0/16E0650 | 689 | COMMIT 689
+(4 rows)

I actually get the "int4" shown as "integer":

# SELECT * FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL);
location | xid | data
-----------+-----+---------------------------------------------------------
0/16B98E0 | 772 | BEGIN 772
0/16B9910 | 772 | table public.data: INSERT: id[integer]:1 data[text]:'1'
0/16B9A18 | 772 | table public.data: INSERT: id[integer]:2 data[text]:'2'
0/16B9AF0 | 772 | COMMIT 772
(4 rows)

The same applies to subsequent examples.

"without loosing any changes"

s/loosing/losing/

"or have are marked as user"

s/are/been/

s/Successfull/Successful/

s/exectuded/executed/

"an replication slot"

s/an/a/

s/paramter/parameter/

I'd have put this in a patch, but I don't know if the output in the
example is wrong, or just dependent on environmental factors.

Regards

Thom

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-03-18 18:16:19 Re: pgsql: Documentation for logical decoding.
Previous Message Andres Freund 2014-03-18 17:53:39 Re: pgsql: Add pg_recvlogical, a tool to receive data logical decoding data