Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-25 20:55:47
Message-ID: CA+hUKGKbWb0ZsWKw-FzYUtcfS=FFUzL+qu6i=Kgj60HVnXEboA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Mar 26, 2022 at 6:52 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I don't think that the Windows CI is running the TAP tests for
> contrib. At least, I can't find any indication of it in the output. So
> it doesn't really help to assess how portable this test is, unless I'm
> missing something.

Yeah :-( vcregress.pl doesn't yet have an easy way to run around and
find contrib modules with tap tests and run them, for the CI script to
call. (I think there was a patch somewhere? I've been bitten by the
lack of this recently...)

In case it's helpful, here's how to run a specific contrib module's
TAP test by explicitly adding it. That'll run once I post this email,
but I already ran in it my own github account and it looks like this:

https://cirrus-ci.com/task/5637156969381888
https://api.cirrus-ci.com/v1/artifact/task/5637156969381888/log/contrib/basebackup_to_shell/tmp_check/log/regress_log_001_basic
https://api.cirrus-ci.com/v1/artifact/task/5637156969381888/log/contrib/basebackup_to_shell/tmp_check/log/001_basic_primary.log

Attachment Content-Type Size
0001-Tests.patch text/x-patch 5.0 KB
0002-HACK-run-tap-tests-in-contrib-basebackup_to_shell.patch text/x-patch 825 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-03-25 21:27:07 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Andrew Dunstan 2022-03-25 20:09:04 Re: pgsql: Add 'basebackup_to_shell' contrib module.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-03-25 21:00:43 Re: Document atthasmissing default optimization avoids verification table scan
Previous Message Robert Haas 2022-03-25 20:40:37 Re: Document atthasmissing default optimization avoids verification table scan