Re: pgsql: Add 'basebackup_to_shell' contrib module.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: 2022-03-25 20:09:04
Message-ID: 7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 3/25/22 13:52, Robert Haas wrote:
> On Fri, Mar 25, 2022 at 12:36 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Create a CF entry for it, or enable CI on a github repo?
> I created a CF entry for it. Then I had to try to Google around to
> find the URL from the cfbot, because it's not even linked from
> commitfest.postgresql.org for some reason. #blamemagnus
>
> I don't think that the Windows CI is running the TAP tests for
> contrib. At least, I can't find any indication of it in the output. So
> it doesn't really help to assess how portable this test is, unless I'm
> missing something.
>
> I looked through the Linux output. It looks to me like that does run
> the TAP tests for contrib. Unfortunately, the output is not in order
> and is also not labelled, so it's hard to tell what output goes with
> what contrib module. I named my test 001_basic.pl, but there are 12 of
> those already. I see that 13 copies of 001_basic.pl seem to have
> passed CI on Linux, so I guess the test ran and passed there. It seems
> like it would be an awfully good idea to mention the subdirectory name
> before each dump of output.

Duplication of TAP test names has long been something that's annoyed me.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2022-03-25 20:55:47 Re: pgsql: Add 'basebackup_to_shell' contrib module.
Previous Message Tomas Vondra 2022-03-25 20:07:50 pgsql: Minor improvements in sequence decoding code and docs

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2022-03-25 20:10:41 Re: logical decoding and replication of sequences
Previous Message Tomas Vondra 2022-03-25 19:58:11 Re: logical decoding and replication of sequences