Re: Refactoring the checkpointer's fsync request queue

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Shawn Debnath <sdn(at)amazon(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactoring the checkpointer's fsync request queue
Date: 2019-04-04 01:01:14
Message-ID: CA+hUKG+2Uri6dzddX3_K2mpWT3dRz-3Dzoja3-a3=3EYrvGEYg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 4, 2019 at 11:39 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> ... Perhaps
> that is an argument for putting the sync handler number *inside* the
> FileTag, since we currently intend to do that with smgr IDs in
> BufferTag (stealing space from ForkNumber).

Here is a version like that. I like it better this way, and the extra
space can be clawed back by using 16 bit types to hold the fork number
and sync handler number.

Here again is the straw-man 0002 patch updated to show how it might
look for another potential user.

--
Thomas Munro
https://enterprisedb.com

Attachment Content-Type Size
0001-Refactor-the-fsync-queue-for-wider-use-v16.patch application/octet-stream 76.9 KB
0002-Use-the-fsync-queue-for-SLRU-files-v16.patch application/octet-stream 16.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-04-04 01:26:50 Re: Simplify redability of some tests for toast_tuple_target in strings.sql
Previous Message Amit Langote 2019-04-04 00:45:08 Re: partitioned tables referenced by FKs