| From: | Shawn Debnath <sdn(at)amazon(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Andres Freund" <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring the checkpointer's fsync request queue |
| Date: | 2019-04-04 04:19:45 |
| Message-ID: | 20190404041945.GA16205@f01898859afd.ant.amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 04, 2019 at 02:01:14PM +1300, Thomas Munro wrote:
> On Thu, Apr 4, 2019 at 11:39 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > ... Perhaps
> > that is an argument for putting the sync handler number *inside* the
> > FileTag, since we currently intend to do that with smgr IDs in
> > BufferTag (stealing space from ForkNumber).
>
> Here is a version like that. I like it better this way, and the extra
> space can be clawed back by using 16 bit types to hold the fork number
> and sync handler number.
+typedef struct FileTag
+{
+ int16 handler; /* SyncRequstHandler value, saving space */
+ int16 forknum; /* ForkNumber, saving space */
+ RelFileNode rnode;
+ BlockNumber segno;
+} FileTag;
Definitely makes sense. v16 looks good to me.
Thanks!
--
Shawn Debnath
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-04 04:22:40 | Re: Checksum errors in pg_stat_database |
| Previous Message | Michael Paquier | 2019-04-04 04:15:31 | Re: Concurrency bug with vacuum full (cluster) and toast |