| From: | Florin Irion <irionr(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Chapman Flack <chap(at)anastigmatix(dot)net>, pgsql-hackers(at)postgresql(dot)org, laurenz(dot)albe(at)cybertec(dot)at |
| Subject: | Re: Reserve prefixes for loaded libraries proposal |
| Date: | 2021-12-01 17:47:40 |
| Message-ID: | CA+HEvJCRTdPohjSVExoW_-u7v_jwrLYEiEZ5H_E1mNq4N6wxvQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Committed.
>
> I made two notable changes: I renamed the function, since it looked
> like EmitWarningsOnPlaceholders() but was doing something not analogous.
Also, you had in your function
>
> strncmp(varName, var->name, varLen)
>
> probably copied from EmitWarningsOnPlaceholders(), but unlike there, we
> want to compare the whole string here, and this would potentially do
> something wrong if there were a GUC setting that was a substring of the
> name of another one.
>
Yeah, it makes sense!
Thank you very much!
Thank you for the changes and thank you for committing it!
Cheers,
Florin
--
*Florin Irion*
*www.enterprisedb.com <http://www.enterprisedb.com>*
Cel: +39 328 5904901
Tel: +39 0574 054953
Via Alvise Cadamosto, 47
59100, Prato, PO
Italia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kenaniah Cerny | 2021-12-01 18:26:32 | Re: Proposal: allow database-specific role memberships |
| Previous Message | Tom Lane | 2021-12-01 17:26:06 | Re: Correct handling of blank/commented lines in PSQL interactive-mode history |