From: | Wenjing Zeng <wjzeng2012(at)gmail(dot)com> |
---|---|
To: | Andrew Bille <andrewbille(at)gmail(dot)com> |
Cc: | wenjing <wenjing(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tony Zhu <Tony(dot)zhu(at)ww-it(dot)cn>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [Proposal] Global temporary tables |
Date: | 2022-01-20 09:53:05 |
Message-ID: | CA+B_3VkPd84PbNehEmhsCxPQspL107BkYsYe93wDuVYpaBXXmg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
very glad to see your reply.
Thank you very much for your review of the code and found so many problems.
There was a conflict between the latest code and patch, I have corrected it
and provided a new patch (V65).
Waiting for your feedback.
Regards, Wenjing.
Andrew Bille <andrewbille(at)gmail(dot)com> 于2022年1月10日周一 17:17写道:
> Hi!
>
> I could not detect crashes with your last patch, so I think the patch is
> ready for a review.
> Please, also consider fixing error messages, as existing ones don't follow
> message writing guidelines.
> https://www.postgresql.org/docs/14/error-style-guide.html
>
I corrected the ERROR message of GTT according to the link and the existing
error message.
Some comments and code refactoring were also done.
>
> Regards, Andrew
>
> On Thu, Dec 23, 2021 at 7:36 PM wenjing <wjzeng2012(at)gmail(dot)com> wrote:
>
>>
>>
>> Andrew Bille <andrewbille(at)gmail(dot)com> 于2021年12月21日周二 14:00写道:
>>
>>> Hi!
>>> Thanks for new patches.
>>> Yet another crash reproduced on master with v63 patches:
>>>
>>> CREATE TABLESPACE ts LOCATION '/tmp/ts';
>>> CREATE GLOBAL TEMP TABLE tbl (num1 bigint);
>>> INSERT INTO tbl (num1) values (1);
>>> CREATE INDEX tbl_idx ON tbl (num1);
>>> REINDEX (TABLESPACE ts) TABLE tbl;
>>>
>> This is a feature made in PG14 that supports reindex change tablespaces.
>> Thank you for pointing that out and I fixed it in v64.
>> Waiting for your feedback.
>>
>
Attachment | Content-Type | Size |
---|---|---|
0001-gtt-v65-reademe.patch | application/octet-stream | 7.5 KB |
0002-gtt-v65-doc.patch | application/octet-stream | 7.5 KB |
0003-gtt-v65-implementation.patch | application/octet-stream | 172.7 KB |
0004-gtt-v65-regress.patch | application/octet-stream | 83.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-01-20 10:50:31 | Re: Null commitTS bug |
Previous Message | Peter Eisentraut | 2022-01-20 09:31:15 | Re: pg_upgrade should truncate/remove its logs before running |