| From: | Jeroen Vermeulen <jtvjtv(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: libpq: PQgetCopyData() and allocation overhead |
| Date: | 2023-02-27 16:08:09 |
| Message-ID: | CA+zULE6aB9Y_CgT_rmGFPpXUuEANmVXi7_RbrZLH7EPhzy3-OA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Done. Thanks for looking!
Jelte Fennema pointed out that I should probably be using PQExpBuffer for
this. I'll look into that later; this is a proof of concept, not a
production-ready API proposal.
Jeroen
On Mon, 27 Feb 2023 at 14:48, Bharath Rupireddy <
bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Fri, Feb 10, 2023 at 5:49 PM Jeroen Vermeulen <jtvjtv(at)gmail(dot)com> wrote:
> >
> > OK, I've updated the PR with a benchmark (in the main directory).
> >
> > On this benchmark I'm seeing about a 24% reduction in "user" CPU time,
> and a 8% reduction in "system" CPU time. (Almost no reduction in
> wall-clock time.)
>
> I can help run some logical replication performance benchmarks
> tomorrow. Would you mind cleaning the PR and providing the changes
> (there are multiple commits in the PR) as a single patch here for the
> sake of ease of review and test?
>
> --
> Bharath Rupireddy
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-02-27 16:08:51 | Re: SLRUs in the main buffer pool - Page Header definitions |
| Previous Message | Heikki Linnakangas | 2023-02-27 16:06:22 | Re: refactoring relation extension and BufferAlloc(), faster COPY |