Fixed PPAS trigger column view condition

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fixed PPAS trigger column view condition
Date: 2014-10-10 12:35:40
Message-ID: CA+yw=mP2SqS--tBeCFfNAZHqP2pBay+2mxJxeW=pMEtdre=zig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

There is one issue with pgadmin while viewing the trigger definition
created for PPAS server as below:

CREATE OR REPLACE TRIGGER tr_a
BEFORE UPDATE *OF cl1 *ON a FOR EACH ROW
begin
if(:new.cl1 < 0) then
insert into a values (:new.*);
END if;
END;

after creating the trigger using above query,column name *cl1*(highlighted
part above) is not visible in property window for that trigger.

In current implementation, there is a condition:

*GetLanguage() != wxT("edbspl"**)* in

*ShowTreeDetail()* and *ReadColumnDetails()* functions in pgTrigger.cpp
file which will prevent it to fetch column name in case db server is PPAS.

I have removed that condition and tested it. It works fine now.
I have attached the same patch with this mail for your reference.
Please review it and if it looks good to you please do the needful.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

Attachment Content-Type Size
trigger_issue.patch application/octet-stream 1.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-10-10 15:54:51 Re: Fixed PPAS trigger column view condition
Previous Message Dave Page 2014-10-09 23:46:26 pgAdmin III commit: Fix copyright date.