| From: | Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, pgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Please add timestamps to pgagent log |
| Date: | 2015-07-16 12:44:24 |
| Message-ID: | CA+yw=mOZR8PbayYM_aL5uuva9GxOPeUMnsYToRZ3gZ-dz8pOpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-support |
Hi Dave,
On Thu, Jul 16, 2015 at 5:56 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Thu, Jul 16, 2015 at 8:19 AM, Sanket Mehta
> <sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > I have created a new patch with changes you have suggested.
> > Please find it attached with this mail.
> >
> > Please do review it.
>
> Doesn't the following break the schema version check in pgAgent.cpp?
>
ADD_DEFINITIONS(-DPGAGENT_VERSION_MAJOR=${CPACK_PACKAGE_VERSION_MAJOR})
> +ADD_DEFINITIONS(-DPGAGENT_VERSION="${VERSION}")
>
No Dave it does not breaking the schema version check in pgAgent.cpp.
I have tested it.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2015-07-16 12:54:53 | Re: Please add timestamps to pgagent log |
| Previous Message | Dave Page | 2015-07-16 12:26:31 | Re: Please add timestamps to pgagent log |