Re: PATCH: improve sorting in the Data Editor

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: improve sorting in the Data Editor
Date: 2015-08-03 05:37:25
Message-ID: CA+yw=mOUc8SUoiGTFwamu2tbhQ+JbW8HASFtPuQQ9CHN=LEUfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Sure Ashesh.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Aug 3, 2015 at 10:49 AM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Sanket,
>
> Can you please review it?
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Sun, Aug 2, 2015 at 3:49 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
>
>> Hello,
>>
>> Here is a small improvement about sorting in the Data editor.
>>
>> Problem:
>> If a table has a PK or OIDs, it gets sorted by PK/OID by default.
>> When a user wants to sort by any other column, he has first to click
>> "Remove sort" in the context menu, and only then click "Sort
>> ascending"(descending) on column of his choice.
>>
>> If he doesn't remove the default sort, he will get no effect and
>> probably be puzzled for the first time until guesses that he makes
>> ORDER BY column_pk, column_of_choice
>> which is totally useless.
>> The need to "Remove sort" each time is annoying.
>>
>> Solution:
>> When a user chooses to sort by some column, we must discard the
>> default sort order.
>>
>> Please see the attached patch.
>> Thanks.
>>
>> --
>> Best regards,
>> J.F.
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2015-08-03 12:38:53 pgAdmin III commit: Bumped version for alpha-2 release (version: 1.22.0
Previous Message Ashesh Vashi 2015-08-03 05:19:36 Re: PATCH: improve sorting in the Data Editor