Re: [PATCH] Add Commit/Rollback toolbar action version 2

From: Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, John Obaterspok <john(dot)obaterspok(at)gmail(dot)com>
Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2
Date: 2015-09-16 09:20:27
Message-ID: CA+yw=mNFpBWqPYB+_S-L34MbH-MqudY3KiduK7p+cLs4aLB1Bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi John,

Patch is not proper.
I got below error when I try to apply the patch:

error: patch failed: pgadmin/frm/frmQuery.cpp:2435
error: pgadmin/frm/frmQuery.cpp: patch does not apply

Please do provide the proper patch.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta <
sanket(dot)mehta(at)enterprisedb(dot)com> wrote:

> Sure Ashesh,
>
> I will review the patch.
>
> Regards,
> Sanket Mehta
> Sr Software engineer
> Enterprisedb
>
> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Sanket,
>>
>> Can you please take a look at it?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok <
>> john(dot)obaterspok(at)gmail(dot)com> wrote:
>>
>>> Hello,
>>>
>>> I'm updated the patch to add commit/rollback actions in the toolbar with
>>> the following:
>>> 1) updated icons (based on existing pgadmin icon with arrows drawn by me)
>>> 2) add entry to menu as well
>>> 3) disable icons when not in a transaction
>>> 4) Ctrl+Shift C|R shortcut
>>>
>>> Hopefully all issues are resolved now!
>>>
>>> Regards,
>>>
>>> John
>>>
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2015-09-16 15:30:44 Re: Patch: New field in frmMain statusbar
Previous Message Adam Scott 2015-09-15 15:01:20 Re: Patch: New field in frmMain statusbar