Re: Parametrization minimum password lenght

Hi all,

we have fixed the following warning from the CFbot:

[07:14:29.637] passwordcheck.c:37:5: error: no previous extern declaration
for non-static variable 'min_password_length'
[-Werror,-Wmissing-variable-declarations]

In attach the fixed patch.

Best regards

Il giorno mer 13 nov 2024 alle ore 17:54 Emanuele Musella <
emamuse86(at)gmail(dot)com> ha scritto:

> Hi Tomas,
>
> we have done the fixes that you have suggested us in the last mail.
>
> 1) Modified passwordcheck.sql with a_nice_long_password and also
> passwordcheck.out
>
> 2) we added the documentation in the doc/src/sgml/passwordcheck.sgml.
>
> 3) we have done make check successfully.
>
> If you have other suggestions to share with us will be welcommed.
>
> Thank you
>
> Best regards
>
>
>
> Il giorno mar 12 nov 2024 alle ore 16:49 Tomas Vondra <tomas(at)vondra(dot)me>
> ha scritto:
>
>> On 11/12/24 16:36, Emanuele Musella wrote:
>> > Hi Tomas,
>> >
>> > thank you for you feedback.
>> >
>> > We have implemented you suggestion in the patch. I attached you the
>> > latest version.
>> >
>>
>> Please always reply to the mailing list, not just directly to individual
>> people. Otherwise others won't see your new messages, it won't get into
>> mailing list archives, etc.
>>
>> > We are waiting for your last feedback to upload the patch on Commitfest.
>> >
>>
>> Not sure I follow. You can add the patch to the commitfest on your own,
>> and there's no need to wait for my feedback before doing so.
>>
>> A couple quick comments for the patch, though:
>>
>> 1) You modified just the SQL script for the test, not the expected
>> output in expected/passwordcheck.out. This means running "make check"
>> for this extension will fail.
>>
>> 2) It's not clear to me why you removed the first ALTER TABLE with
>> a_nice_long_password. Seems wrong.
>>
>> 3) The test doesn't change the new GUC at all, so how would this show
>> the setting actually affects anything? And you only test the "positive"
>> case, maybe it'd be good to change the GUC and then test that it rejects
>> a password.
>>
>> 4) The new GUC needs to be added to doc/src/sgml/passwordcheck.sgml.
>>
>>
>> regards
>>
>> --
>> Tomas Vondra
>>
>>