Re: Patch: New field in frmMain statusbar

From: Adam Scott <adam(dot)c(dot)scott(at)gmail(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch: New field in frmMain statusbar
Date: 2015-09-14 13:34:39
Message-ID: CA+s62-PDmPApuCvzAziewCtZnDD1sAkOwnnwW6odhWaXE2hF+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

thank you for your time to consider this patch.

Here's a few screenshots on my Windows 7 desktop. Let me know if you want
to see anything else.
A few observations:

[image: Inline image 1]
[image: Inline image 2]

On Mon, Sep 14, 2015 at 4:43 AM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:

> I don't have a working pgadmin env at the moment - any chance someone who
> has built it could show a screenshot?
>
> I've certainly had customers complain about pgadmin in the case of many
> databases, though it's generally been on account of performance, and not
> something like this.
>
> //Magnus
>
>
> On Mon, Sep 14, 2015 at 10:57 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks Adam.
>>
>> What do others feel about this proposed patch? I can see how it might
>> be useful, however I'm also concerned about overloading the UI with
>> more info - and in over a decade I don't recall anyone ever asking for
>> this feature or complaining of the issue Adam describes (though, it is
>> clearly feasible).
>>
>> On Sun, Sep 13, 2015 at 4:19 PM, Adam Scott <adam(dot)c(dot)scott(at)gmail(dot)com>
>> wrote:
>> > Hi,
>> >
>> > please consider this patch to frmMain.
>> >
>> > Situation: When a user has a large number of databases and connections,
>> > when they select a table or other object in the Object browser tree,
>> they
>> > can lose track of which connection and database the object belongs too.
>> > This makes it really easy for the user to make a mistake and drop an
>> object
>> > on the wrong connection (such as on a Production server instead of a
>> > Development server). Also as a user is browsing multiple databases and
>> > connections they can lose track of which object they are working on.
>> >
>> > Solution: This patch adds a new field in the status bar of the main
>> window
>> > (frmMain), between the two other fields, keeping them the same. If
>> there's
>> > a currently selected object the field will display it's connection and
>> > database. If there's no currently selected object, it will be blank.
>> >
>> > Here's the danger, if we display the wrong connection and database, the
>> user
>> > could drop the wrong object. So it's imperative this never has a bug.
>> This
>> > code change is so small with so little dependencies, it relies on
>> already
>> > used code for such a long time that if it had a bug, then there are
>> other
>> > bigger bugs in the code that would have already shown up.
>> >
>> > Regards,
>> > Adam C. Scott
>> >
>> > patch generated using Tortoise Git Create Patch Serial
>> >
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2015-09-14 16:11:29 Re: Patch: New field in frmMain statusbar
Previous Message Prasad Somwanshi 2015-09-14 11:23:10 Re: Patch : PGPASSFILE fix