From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
---|---|
To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Check lateral references within PHVs for memoize cache keys |
Date: | 2023-07-08 05:24:27 |
Message-ID: | CA+renyX=40YXhsfPTzn13oNOPO3TJ12CK9GX-2P2pvnQiScefA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jul 4, 2023 at 12:33 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> Rebase the patch on HEAD as cfbot reminds.
All of this seems good to me. I can reproduce the problem, tests pass,
and the change is sensible as far as I can tell.
One adjacent thing I noticed is that when we renamed "Result Cache" to
"Memoize" this bit of the docs in config.sgml got skipped (probably
because of the line break):
Hash tables are used in hash joins, hash-based aggregation, result
cache nodes and hash-based processing of <literal>IN</literal>
subqueries.
I believe that should say "memoize nodes" instead. Is it worth
correcting that as part of this patch? Or perhaps another one?
Regards,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-07-08 05:36:49 | Re: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL |
Previous Message | Michael Paquier | 2023-07-08 04:48:49 | Re: Add hint message for check_log_destination() |