From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
---|---|
To: | a(dot)parfenov(at)postgrespro(dot)ru |
Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Range phrase operator in tsquery |
Date: | 2018-11-15 22:15:07 |
Message-ID: | CA+q6zcXyRY6kKpuXAJgvznyA0Jj3tOe=XkQ1n7e3XaE44ZW1Rw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Fri, 27 Apr 2018 at 13:03, Aleksandr Parfenov <a(dot)parfenov(at)postgrespro(dot)ru> wrote:
>
> Nowadays, phrase operator in Postgres FTS supports only exact match of
> the distance between two words. It is sufficient for a search of
> simple/exact phrases, but in some cases exact distance is unknown and we
> want to words be close enough. E.g. it may help to search phrases with
> additional words in the middle of the phrase
Hi,
Thank you for the patch, it looks like a nice feature. Few questions:
+ if (!distance_from_set)
+ {
+ distance_from = distance_to < 0 ? MINENTRYPOS : 0;
+ }
+ if (!distance_to_set)
+ {
+ distance_to = distance_from < 0 ? 0 : MAXENTRYPOS;
+ }
Why use 0 here instead of MAXENTRYPOS/MINENTRYPOS ? It looks a bit strange:
SELECT 'a <,-1000> b'::tsquery;
tsquery
------------------------
'a' <-16384,-1000> 'b'
(1 row)
SELECT 'a <,1000> b'::tsquery;
tsquery
------------------
'a' <0,1000> 'b'
(1 row)
Also I wonder why after introducing MINENTRYPOS the LIMITPOS wasn't changed?
#define LIMITPOS(x) ( ( (x) >= MAXENTRYPOS ) ? (MAXENTRYPOS-1) : (x) )
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2018-11-15 22:22:59 | Re: A small tweak to some comments for PartitionKeyData |
Previous Message | Peter Eisentraut | 2018-11-15 22:13:32 | Re: Some incorrect comments and out-dated README from run-time pruning |