| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp |
| Cc: | ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Protect syscache from bloating with negative cache entries |
| Date: | 2018-12-01 12:59:50 |
| Message-ID: | CA+q6zcXw9jUJCwPBqo=NAELj_TporkBPAuGdqV3hDbrzRGEeTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Tue, Nov 27, 2018 at 11:40 AM Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>
> The attached is the rebased version that has multidimentional
> ageclass.
Thank you,
Just for the information, cfbot complains about this patch because:
pgstatfuncs.c: In function ‘pgstat_get_syscache_stats’:
pgstatfuncs.c:1973:8: error: ignoring return value of ‘fread’,
declared with attribute warn_unused_result [-Werror=unused-result]
fread(&cacheid, sizeof(int), 1, fpin);
^
pgstatfuncs.c:1974:8: error: ignoring return value of ‘fread’,
declared with attribute warn_unused_result [-Werror=unused-result]
fread(&last_update, sizeof(TimestampTz), 1, fpin);
^
I'm moving it to the next CF as "Waiting on author", since as far as I
understood you want to address more commentaries from the reviewer.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-12-01 13:05:07 | Re: jsonpath |
| Previous Message | Dmitry Dolgov | 2018-12-01 12:47:27 | Re: Refactoring the checkpointer's fsync request queue |