| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, adrien(dot)nayrat(at)anayrat(dot)info, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, david(dot)rowley(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-17 23:47:12 |
| Message-ID: | CA+q6zcX8k3otLDR13fwm7S16sZdVemQo6Vv9XckJBdp-qw6sQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mon, 16 Jul 2018 at 23:07, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> On 07/16/2018 05:24 PM, Robert Haas wrote:
> > On Sun, Jul 15, 2018 at 6:53 AM, Vik Fearing
> > <vik(dot)fearing(at)2ndquadrant(dot)com> wrote:
> >> Hmm. Not sure if that last word should be _sample, _sampling, _rate, or
> >> a combination of those.
> >
> > +1 for rate or sample_rate. I think "sample" or "sampling" without
> > "rate" will not be very clear.
> >
>
> 1+ to sample_rate
>
> It's what auto_explain and pgbench uses, so let's keep the naming
> consistent.
This patch went through last few commitfests without any activity, but cfbot
says it still applies and doesn't break any tests. From what I see there was
some agreement about naming, so the patch is indeed needs more review. Could
anyone from the reviewers (Vik?) confirm that it's in a good shape?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-11-18 02:20:45 | Re: Postgres, fsync, and OSs (specifically linux) |
| Previous Message | Justin Pryzby | 2018-11-17 23:37:15 | Re: pg11.1 jit segv |