| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | julien(at)jdemoor(dot)com |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, iacobcatalin(at)gmail(dot)com |
| Subject: | Re: NOTIFY and pg_notify performance when deduplicating notifications |
| Date: | 2018-11-30 22:35:59 |
| Message-ID: | CA+q6zcWwW5DJ8Yrxi+hSDyA4HsEF=n5X=Q+9c8Nb+M2j5sKg7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mon, Nov 19, 2018 at 8:30 AM Julien Demoor <julien(at)jdemoor(dot)com> wrote:
>
> Thank you for the review. I've addressed all your points in the attached
> patch. The patch was made against release 11.1.
I've noticed, that cfbot complains about this patch [1], since:
Duplicate OIDs detected:
3423
found 1 duplicate OID(s) in catalog data
At the same time it's quite minor problem, so I'm moving it to the nexc CF as
"Needs review".
Also since it's performance related patch, and the latest tests I see in the
history of this topic were posted around the time of the initial thread (which
was quite some time ago), could we expect to see some new benchmarks with this
patch and without? Probably the positive difference would be obvious, but
still.
[1]: https://travis-ci.org/postgresql-cfbot/postgresql/builds/461617098
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-11-30 22:57:21 | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |
| Previous Message | Alvaro Herrera | 2018-11-30 22:19:35 | Re: doc - improve description of default privileges |