Re: de-deduplicate code in DML execution hooks in postgres_fdw

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: de-deduplicate code in DML execution hooks in postgres_fdw
Date: 2018-11-29 17:58:07
Message-ID: CA+q6zcUz_eaX0v2hKK=5hRNzR0Fi3cnyJshNo5tCgkd2zQfUMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Oct 1, 2018 at 2:55 PM Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>
> (2018/10/01 19:42), Michael Paquier wrote:
> > On Mon, Jul 23, 2018 at 02:17:38PM +0530, Ashutosh Bapat wrote:
> > Fujita-san, you are registered as a reviewer of this patch. Are you
> > planning to look at it soon?
>
> Yeah, I'm planning to work on this immediately after fixing the issue
> [1], because it still seems to me wise to work on it after addressing
> that issue. (I'll post an updated version of the patch for that tomorrow.)

Yep, it would be nice to have a full review here. But as far as I see the issue
you were talking about is still in progress, right? Also looks like someone
needs to take over this rather small patch.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-11-29 17:59:25 Re: [PROPOSAL] extend the object names to the qualified names in pg_stat_statements
Previous Message Dmitry Dolgov 2018-11-29 17:48:12 Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory