| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Generic type subscripting |
| Date: | 2018-01-30 15:47:39 |
| Message-ID: | CA+q6zcUPeGhtNDqXo65o87Zfjjs0T5E0=+ab3nax9VXKch6LXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 29 January 2018 at 14:41, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>
> I have a few comments.
Thanks for suggestions, I've incorporated all of them in a new version of the
patch.
> SbsRoutines is not good name for me. SubscriptRoutines or
> SubscriptingRoutines sound better and it is consistent with other
> structures.
In general I agree, and I thought about that while implementing this structure.
But my concern is that some parts of subscripting infrastructure are annoyingly
verbose, maybe it makes sense to come up with a short abbreviation and use it
everywhere across this code.
| Attachment | Content-Type | Size |
|---|---|---|
| 0005-Subscripting-documentation-v7.patch | text/x-patch | 18.7 KB |
| 0004-Subscripting-for-jsonb-v7.patch | text/x-patch | 32.9 KB |
| 0003-Subscripting-for-array-v7.patch | text/x-patch | 12.8 KB |
| 0002-Base-implementation-of-subscripting-mechanism-v7.patch | text/x-patch | 127.0 KB |
| 0001-Renaming-for-new-subscripting-mechanism-v7.patch | text/x-patch | 44.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-30 15:59:32 | Re: [HACKERS] MERGE SQL Statement for PG11 |
| Previous Message | Robert Haas | 2018-01-30 14:35:50 | Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory |